Prio 0.3#321
Draft
FedericoCeratto wants to merge 1 commit into
Draft
Conversation
FedericoCeratto
force-pushed
the
url-prio-5
branch
from
1e55742 to
1dc5820
Compare
3 tasks
hellais
reviewed
Jul 22, 2020
| @metrics.timer("generate_test_list") | ||
| def generate_test_list(country_code: str, category_codes: str, limit: int): | ||
| global test_items, last_update_time | ||
| global test_items, next_update_time |
Member
There was a problem hiding this comment.
I wonder if there is a nicer way to do this without having global variables.
hellais
reviewed
Jul 22, 2020
| } | ||
| ) | ||
| metrics.incr("total_urls_served", count=len(out)) | ||
| metrics.incr(f"country_code_requested[cc={country_code}]") |
Member
There was a problem hiding this comment.
Is the country_code guaranteed to always be uppercase or lowercase? Do you maybe want to normalise it at the beginning?
hellais
approved these changes
Jul 22, 2020
hellais
left a comment
hellais
left a comment
Member
There was a problem hiding this comment.
Left few nitpick comments, otherwise good to go! 🐳
Contributor
Author
|
Superseded by #324 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor, improve metrics
(Created grafana dashboard)