feat: machineconfig-restore capability + 5 unit tests (session/25)#41
Merged
Conversation
…ion/25)
Adds machineconfig-restore named capability: reads TalosMachineConfigRestore
CR for backupTimestamp/s3SourceBucket/targetNodes, downloads per-node config
from S3 at {cluster}/machineconfigs/{ts}/{hostname}.yaml, applies via
ApplyConfiguration, waits for node stable. Non-fatal per node. Registers
handler in stubs.go. Adds CapabilityMachineConfigRestore constant to
runnerlib. conductor-schema.md §6, platform-schema.md §11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CapabilityMachineConfigRestore = "machineconfig-restore"constant topkg/runnerlib/constants.go.machineConfigRestoreHandler.Execute(): readsTalosMachineConfigRestoreCR forbackupTimestamp/s3SourceBucket/targetNodes, downloads per-node config from S3 at{cluster}/machineconfigs/{ts}/{hostname}.yaml, applies viaApplyConfiguration, waits for node stable. Non-fatal per node -- failures recorded in Steps, continues to remaining nodes. ReturnsExecutionFailureonly when all nodes fail.stubs.go.Test plan
go test ./internal/capability/... -run TestMachineConfigRestore-- all 5 PASS (confirmed locally)go test ./...-- all pass (confirmed locally)