Bump up ONNX for scikit-build-core support#308
Merged
Conversation
Signed-off-by: take-cheeze <takechi101010@gmail.com>
Signed-off-by: take-cheeze <takechi101010@gmail.com>
Signed-off-by: take-cheeze <takechi101010@gmail.com>
justinchuby
reviewed
Jun 1, 2026
| )"; | ||
| onnx::ModelProto model; | ||
| const onnx::Status status = onnx::OnnxParser::Parse(model, graph_str); | ||
| const onnx::Common::Status status = onnx::OnnxParser::Parse(model, graph_str); |
Member
There was a problem hiding this comment.
This seems strange. onnx::Status seems to be the right name we should expose. Was there anything that was changed or need fixing in onnx?
Member
Author
There was a problem hiding this comment.
This seems to be caused by https://github.com/onnx/onnx/pull/7622/changes#diff-c2cee98ca3f270d79c2ef075c84960941a092b896dbfae881092a0c79b1b0d7eL20
cpplint seems to warn it: https://github.com/cpplint/cpplint/blob/fa09262f61706cad2aacc0a0e1f1f3bf06a3b042/cpplint.py#L6213
Signed-off-by: take-cheeze <takechi101010@gmail.com>
Signed-off-by: take-cheeze <takechi101010@gmail.com>
Member
Author
|
onnxsim/onnxsim#436 is depending on this since onnx/onnx#7614 needs to be merged |
justinchuby
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rel onnx/onnx#8017
Now adds
ONNX_INSTALLvariable to fix cmake error while building python module