chore(ui): remove dead server-rendered detail/list DivKit builders#242
Open
mikedegeofroy wants to merge 1 commit into
Open
chore(ui): remove dead server-rendered detail/list DivKit builders#242mikedegeofroy wants to merge 1 commit into
mikedegeofroy wants to merge 1 commit into
Conversation
PR #241 made the record surface serve the entity form directly, leaving SurfaceDivBuilder.catalogDetail/documentDetail (and the legacy server-rendered list builders replaced earlier by the onno-list island) reachable only from their own unit tests. Remove them, their private helper chain, the Components members only they used (field rows, table stack, status badge, action button), and the tests that exercised them. Kept: listSurface/listDescriptor, entityForm, registerSurface, withComments, HeaderAction/actionItems, and the Components primitives the dashboard/page/login builders still use. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #241 (record surface serves the entity form directly): the server-rendered DivKit detail builders became dead code reachable only from their own unit tests. This removes them.
Removed from
SurfaceDivBuilder:catalogDetail(...)/documentDetail(...)(all overloads) and their helper chain:detailHeader,actionCluster,relatedListTable/relatedListTitle,fieldCard,sectionLabel,fieldRowFor,cell,visible,systemColumnFormat/Label,refUrlFor,routeNameOf, the widget detectors,splitGallery,maskSecretcatalogList/documentList/catalogRows/documentRows/listContent/rowsStack/rowsPatch+ cell helpers) — superseded by theonno-listisland well before feat(ui): combine record detail and edit pages into one editable surface #241, also test-only by nowRemoved from
Components: members only the above used — the field-row family (fieldRow,pillFieldRow,refFieldRow,imageFieldRow,fileFieldRow,imageGalleryRow,geoFieldRow), the table stack (table,tableItems,tableStack,scrollX,Row, width fitting),statusBadge/badge,actionButton,tabs,labelCell,readableTextColor.Removed tests:
CatalogDetailRelatedListTest,DocumentDetailRelatedListTest,RefLinkTest,EnumColorPillDetailTest,SystemColumnDetailLabelTest,FileFieldRowTest— they exercised the removed rendering; the behaviors (ref links, enum pills, file/image rows, system-column labels) live in the React form now with its own coverage.Kept (still used):
listSurface/listDescriptor,entityForm,registerSurface+ helpers,withComments,HeaderAction/actionItems, and theComponentsprimitives the dashboard/page/login builders use (icon,hint,pageHeader,card).Net: −1,145 lines, no behavior change.
Verify
./gradlew :onno-ui-starter:check :example:checkgreen.🤖 Generated with Claude Code