moving away from sync locks - #70
Merged
Merged
Conversation
kickhead13
requested review from
AlexDuna,
Doru991,
OllieOlafsson,
Tamas-Tudor-Ciprian and
iv-panzer
June 12, 2026 17:05
Tamas-Tudor-Ciprian
approved these changes
Jun 24, 2026
Tamas-Tudor-Ciprian
left a comment
Tamas-Tudor-Ciprian
left a comment
Contributor
There was a problem hiding this comment.
Mechanically this will fix the linter and its cool that we won't have poisoned locks anymore.
But I will look further into it and propose changes in the near future because I think mutexes might be completely useless since scylla::Session is arc based.
Good work, sorry for late review.
Doru991
approved these changes
Jun 24, 2026
Doru991
left a comment
Doru991
left a comment
There was a problem hiding this comment.
I don't think it'll cause any problems, let's get it merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last linting warning that we ignore... this should fix it...