Skip to content

New settings layout - #48

Open
catyuzu23 wants to merge 11 commits into
mainfrom
catyuz-setttings
Open

New settings layout#48
catyuzu23 wants to merge 11 commits into
mainfrom
catyuz-setttings

Conversation

@catyuzu23

@catyuzu23 catyuzu23 commented Mar 23, 2026

Copy link
Copy Markdown
Member

It is a part of the new settings layout and an update for some dependencies versions used.
image

@kickhead13

Copy link
Copy Markdown
Member

Please notice we disabled some CI (temporarly)

},
clearFile() {
if (this.newFileUrl) {
try { URL.revokeObjectURL(this.newFileUrl); } catch {/* Silently ignore errors from revokeObjectURL*/ }

@catyuzu23 catyuzu23 Apr 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only change for last commit is here the rest is formatting for the text

@kickhead13 kickhead13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kickhead13 kickhead13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well two more small comments should be handled and then we could merge it

font-size: 16px;
background: var(--settings-surface);
color: var(--settings-text);
box-shadow: 0 0 6px rgba(128, 128, 128, 0.5);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOPS can this rgba be made a variable?
And be used here like

var(--box-shadow-something-something)


.settings-danger-btn:hover,
.sidebar-logout:hover {
background: rgba(208, 66, 66, 0.26);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rgba should also be made into a variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants