core(sec): remove TLS certificates and improve encryption (+other fixes) - #3
Merged
Conversation
added 4 commits
February 13, 2026 18:10
Our old (and very dangerous) strategy was to import TLS certificates for HTTPS straight into the image of ash tray at build time. This is stupid and for sure not a good idea. Instead of doing this we (for now) will allow nginx to handle pathing and certificates. This change also enables as to deploy this component to k8s which will then be handling the certificates. On top of this, I also improved both content quality and encryption safety in this PR by swapping basic AES encryption with AES-GCM (Galois/Counter Mode), which assures data integrity and also handles data of different sizes that is not excatly in sync with block sizes.
kickhead13
requested review from
AlexDuna,
Doru991,
OllieOlafsson and
iv-panzer
February 13, 2026 17:35
AlexDuna
approved these changes
Feb 16, 2026
AlexDuna
left a comment
AlexDuna
left a comment
Member
There was a problem hiding this comment.
I believe the changes are fine.
Doru991
approved these changes
Feb 16, 2026
Doru991
left a comment
Doru991
left a comment
There was a problem hiding this comment.
Not exactly my area of expertise but should be fine as far as I can see.
|
Note: Due to the file upload endpoint modification, we should wait until the frontend has a corresponding PR and merge both at the same time. |
added 2 commits
February 26, 2026 11:26
...HOW THE FUCK DID IT WORK BEFORE
kickhead13
pushed a commit
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our old (and very dangerous) strategy was to
import TLS certificates for HTTPS straight into
the image of ash tray at build time. This is stupid
and for sure not a good idea.
Instead of doing this we (for now) will allow nginx
to handle pathing and certificates. This change
also enables as to deploy this component to k8s
which will then be handling the certificates.
On top of this, I also improved both content quality
and encryption safety in this PR by swapping
basic AES encryption with AES-GCM (Galois/Counter
Mode), which assures data integrity and also handles
data of different sizes that is not excatly in sync
with block sizes.