feat: pretty printing#5
Open
onefloid wants to merge 6 commits into
Open
Conversation
To archive the old beaviour add the --output-raw option to your cli call
…local # Conflicts: # poetry.lock
- utils/generic.py: narrow the broad except in execute_exists() so it no longer swallows typer.Exit. Since typer.Exit subclasses RuntimeError/Exception, resolve_database()'s print_error_and_exit() call (e.g. for an unknown --database name) was being re-caught and produced a spurious extra "Exit:" line after the real error message. - utils/generic.py: replace the attribute_name[:-1].capitalize() depluralization with an explicit SINGULAR_NAMES mapping, since stripping one character mangled "processes" into "Processe" instead of "Process". - utils/generic.py: add the missing `# pylint: disable=redefined-builtin` on `from rich import print`, matching project convention and fixing the CI pylint failure. - main.py, commands/process.py: switch `from typing_extensions import Annotated` to the stdlib `from typing import Annotated`, matching the other command modules. Newer typer releases (needed after loosening the typer version constraint on main) no longer pull in typing_extensions transitively, so the old import broke on a fresh install. - tests: update test_cmd_cubes.py, test_cmd_subset.py and test_cmd_view.py assertions for the new pretty-printed output and add --output-raw coverage, mirroring the pattern already used in test_cmd_dimension.py. Closes the "Update all tests" item from the PR description. - README.md: document the new --output-raw flag. Closes the "Update readme" item from the PR description. Verified: full mocked test suite (19/19) and pylint (10.00/10) pass on a fresh install of the branch's dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Open tasks before Merge
Issues
Closes #4