Skip to content

CI: Workaround duplicated release creation #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larskanis merged 1 commit into from
Oct 8, 2025
Merged

CI: Workaround duplicated release creation #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/ruby_installer/build/release.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,17 @@ def upload_to_github(tag:, repo:, token: nil, files:)
)
end

old_assets = client.release_assets(release.url)
# Recheck all releases to avoid duplicated release creation
release2 = nil
(1..100).find do |page|
release2 = client.releases(repo, page: page).find{|r| r.tag_name==tag }
end
# Did we create a second release in parallel?
if release.id != release2.id
client.delete_release(release.url)
end

old_assets = client.release_assets(release2.url)

files.each do |fname|
if old_asset=old_assets.find{|a| a.name == File.basename(fname) }
Expand All @@ -114,7 +124,7 @@ def upload_to_github(tag:, repo:, token: nil, files:)
end

$stderr.print "Uploading #{fname} (#{File.size(fname)} bytes) ... "
client.upload_asset(release.url, fname, content_type: CONTENT_TYPE_FOR_EXT[File.extname(fname)])
client.upload_asset(release2.url, fname, content_type: CONTENT_TYPE_FOR_EXT[File.extname(fname)])
$stderr.puts "OK"
end
end
Expand Down
Loading