Skip to content

eunit: de-dup deps by app_name so test target wins over prod variant #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastiw merged 1 commit into from
Jun 25, 2026
+9 −3
Merged

eunit: de-dup deps by app_name so test target wins over prod variant #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions private/eunit.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
load(
"//:erlang_app_info.bzl",
"ErlangAppInfo",
"flat_deps",
)
load(
"//:util.bzl",
Expand Down Expand Up @@ -48,10 +49,15 @@ def _quote(string_list_term):
return string_list_term.replace('"', '\\"')

def _impl(ctx):
deps = list(ctx.attr.deps)
lib_info = ctx.attr.target[ErlangAppInfo]
deps.extend(lib_info.deps)
deps.append(ctx.attr.target)

# The test target must come first so that flat_deps's first-wins
# de-dup by app_name picks the test variant over any prod variant
# of the same app pulled in transitively via test_deps cycles
# (e.g. app A depends on B in test_deps, and B depends on A).
# Without this, two ErlangAppInfos sharing an app_name would both
# try to symlink their .beam files to the same ERL_LIBS path.
deps = flat_deps([ctx.attr.target] + list(ctx.attr.deps) + lib_info.deps)

# Use the eunit_mods attribute if provided, otherwise calculate from beam and test_beam
# Note: when eunit_mods is not provided, we need to include both:
Expand Down
Loading