Remove S3 handling#108
Conversation
|
https://github.com/ome/ome-common-java/blob/master/location-server/start-location.sh can likely go as well. |
|
From discussion yesterday at the OME Formats meeting, the current proposal is to deprecate these APIs in Bio-Formats 8.4.0 in preparation for their removal from the |
|
Closing/reopening to trigger the CI workflow |
|
Thanks Seb. Sorry, didn't see that workflow wasn't triggered. |
sbesson
left a comment
There was a problem hiding this comment.
Thanks @dominikl. Comparing the changes against the content of the original PR which introduced this functionality, noting a few additional places that should be cleaned up:
location-serverpom.xml: thejackson-*dependenciesStreamHandle: the internalSettingsclassLocation:- the
UrlTypeenum - the
isURL,urlTypeanduriprivate fields - the internal code paths that depend on these enum and fields
- a few unused imports
- the
e9bedb5 to
b7158bb
Compare
sbesson
left a comment
There was a problem hiding this comment.
One question about a dependency. Otherwise, this is looking good and both the nightly builds in OME CI and the repository tests have been passing with this included so we know it did not cause any obvious regression.
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> |
There was a problem hiding this comment.
Is there a reason to keep jackson-databind?
This PR removes
miniodependency (and therefore S3 handling, has been deprecated already), it is actually not used anywhere.