.vsi fill color fixes#4445
Open
melissalinkert wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to make the default fill color for missing image data line up with what OlyVIA shows.
A default background color may be defined for each pyramid in the .vsi dataset. This change as written applies first applies the user-defined fill color (or 0 if not specified), then applies the pyramid fill color in the .vsi metadata (if found). This means that e.g.
showinf -fill 255 ...will not show 255 for missing data if a pyramid fill color is found. I am open to changing the order of precedence though.Right now just opening to see which tests might fail; I don't have specific test data just yet.