fix(client): rc.7 keyed settings.plugin.item + dsh peer floor - #59
Merged
Conversation
rc.7 moved settings.plugin.item from a list slot (id + order) to a keyed slot: options.key is the settings namespace the card edits, and the slot runtime throws when it is missing, which crashed apps/web with 'Failed to load plugins'. Register key 'advisor' (the already-installed advisor namespace, spelled as a literal because the host-half settings module is outside the client bundle externals) and drop id/order. Pin the key in the registration spec so a missing or wrong key fails the suite. Also bump every @deepseek-ai/dsh-* peerDependency to ^0.1.0-rc.7 (same caret) so dev-time types match the running rc.7 host; cordis/schemastery/ react unchanged, peers stay peerDependencies only. Sync the lockfile and the workspace minimumReleaseAgeExclude pins to rc.7, and update docs/ comments that still described the old list-slot shape or rc.6 pin.
This was referenced Aug 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
dsh 0.1.0-rc.7 web fails to load this plugin:
rc.7 moved
settings.plugin.itemfrom a list slot (id/order) to a keyed slot (key= settings namespace).What
{ name: 'settings.plugin.item', key: 'advisor', locale, inject }(noid/order).@deepseek-ai/dsh-*peer to^0.1.0-rc.7(user-directed).cordis/schemastery/reactunchanged.tests/peer-deps.test.tsand the registration spec; surgical docs wording.Out of scope
settingsScopemigration (gateway channel kept).dsh-llm-fallbackshas the same crash class (id: 'fallbacks').Verify
pnpm typecheck/pnpm test(377) /pnpm buildgreen on the feature branch.