feat(advisor): TUI settings write surface — tuiSettingsSections Advisor section (dsh-tui /settings) - #56
Merged
Conversation
…advisor edit paths
…se test + upstream pin + hygiene (S-001/S-002/S-1/N-3)
… for the tuiSettingsSections seam (post-#165)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iteration iter-20260817-dsh-advisor-n9
Adapt the advisor's settings to the new dsh-tui settings seam (
tuiSettingsSections, shipped in dsh-tui v0.8.0 — upstream issuedsh-TUI#165/PR #238). This delivers the n8 Roadmap "Next" TUI settings write surface, this-repo only (zero dsh-TUI changes, zero new peers).Deliverable
src/tui-settings.ts— register an editable Advisor section on thetuiSettingsSectionsseam: fieldsenabled/provider/model/immuneTurns/maxDeltaMessages(zh/en labels + hints).systemPromptis intentionally NOT a TUI field (single-line input truncation risk — edited via the web card /$DSH_HOME/settings.yaml). SharedTUI_SETTINGS_SECTIONSservice-key constant drives both the registration and the/advisor confighint probe. Conditional inject → clean no-op on dsh-tui < v0.8.0 / non-TUI hosts; multi-fiber duplicate-ns contained; registered only on the single-reviewer (claiming) fiber.src/commands.ts+src/index.ts—/advisor configstays a session-less read-only readback; its edit hint is now truthful: lists the TUI/settingsscreen (Advisor section) when the seam is mounted, else the n8 text./settings, profile patch, shared$DSH_HOME/settings.yaml), thesystemPromptexclusion, the web-card-vs-TUI save-behavior difference (S4 explicit model gate still resolves disabled-with-reason), and the dsh-tui ≥ v0.8.0 requirement.Gates
iteration/iter-20260817-dsh-advisor-n9(base = currentmain).b2e0381→ targeted re-review Approve ×3 — Approve clean, no open R#.b2e0381— AC-1..AC-6 deterministic PASS (realdsh-settings-filewrite path 3→5 / 60→100 lands in thesettings.yamluser layer + live re-apply; schema backstop2.5/-1rejected whole-save nothing stored; both hint branches byte-exact;/advisorstatus/config live; web profile intact;typecheck/ 377 tests /buildgreen). Residuals R1–R6 = interactive human spot-checks (PTY blocked in the QA sandbox) — recorded inqa.md.dsh-tui-plugin-client-surface.mdfor the post-#165 seam (S1–S6 stale claims corrected); compasscompleted+end_date; close gate PASS.PR merge remains manual (not auto-merge). In a real dsh-tui v0.8.0 terminal:
dsh --profile dsh-tui→/settings→ edit the Advisor section → save →/advisor configreflects the change.