Recognize a local Ollama endpoint as configured in the setup wizard#275
Open
omatheusmesmo wants to merge 1 commit into
Open
Recognize a local Ollama endpoint as configured in the setup wizard#275omatheusmesmo wants to merge 1 commit into
omatheusmesmo wants to merge 1 commit into
Conversation
SetupState.llmConfigured() treated the placeholder LLM_API_KEY=dummy that the ./run.sh local Ollama stack ships as unconfigured, so a working local install was nagged by the first-run setup banner. Detect a loopback or self-hosted (Ollama) primary base-url and count it as configured even with a placeholder key. Extract the URL check as a pure static and cover it with a unit test (adds junit5 + the empty argLine property the plain-Java unit test needs under Java 25). Signed-off-by: Matheus Oliveira <matheus.6148@gmail.com>
Contributor
|
🚀 Docs preview for 4c4ab09 is live: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The first-run setup wizard nagged a working local install to "set up an LLM".
SetupState.llmConfigured()treated the placeholderLLM_API_KEY=dummythat the./run.sh localOllama stack ships as unconfigured. Now a loopback or self-hosted (Ollama) primary base-url counts as configured even with a placeholder key.How
isLocalEndpoint(String).argLineproperty a plain-Java unit test needs under Java 25 (same pattern ascomposition-model).Verification
mvn install -pl console/deployment -am -DskipTests(compile + extension-descriptor) and the unit test both pass.