Skip to content

boot: add --append flag for extra kernel bootargs#201

Merged
olofj merged 1 commit into
olofj:mainfrom
asrinivasanTT:asrinivasan/append_bootargs
May 12, 2026
Merged

boot: add --append flag for extra kernel bootargs#201
olofj merged 1 commit into
olofj:mainfrom
asrinivasanTT:asrinivasan/append_bootargs

Conversation

@asrinivasanTT

Copy link
Copy Markdown
Contributor

Adds the ability to extend the kernel commandline while doing bhx boot

@asrinivasanTT asrinivasanTT force-pushed the asrinivasan/append_bootargs branch from ea79bb7 to 76059a2 Compare May 12, 2026 05:49
@asrinivasanTT asrinivasanTT force-pushed the asrinivasan/append_bootargs branch from 76059a2 to 890cd95 Compare May 12, 2026 05:59
@olofj

olofj commented May 12, 2026

Copy link
Copy Markdown
Owner

No real concerns with this patch, with two minor comments:

  1. --append is a bit generic, and it maps over to another name in the sources. It might be what tt-bh-linux uses though? --extra-bootargs would maybe be a better name. I'm not super fussed about it though, it can stay as it is.

  2. The functions are taking tons of arguments in these areas of the code and this adds one more. I filed Cleanup sweep: simplify awkward internal APIs (param packs, redundant indices, leaky abstractions) #198 yesterday to clean up and refactor them. So this is just a heads up that there'll be some churn in those files soon to clean up the API, so this code will be touched as part of that.

Given (2) and to not hold things up on the refactor, I'll merge this now. Thanks for the PR!

@olofj olofj merged commit eb22dbe into olofj:main May 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants