Conversation
…sagePartRenderer update conversations: ChatView, MessagePartRenderer
…sagePartRenderer update conversations: ChatView, MessagePartRenderer
…ction, MessagePartRenderer update conversations: CollapsibleSection, MessagePartRenderer
…nderer, toolResultTracker update conversations: MessagePartRenderer, toolResultTracker
…n isNew detection Forward the `isLoading` state through the component tree to `ToolResultPartRenderer` and use it to collapse tool results on tick changes. Fix a race condition in the tool result tracker where the `loading()` signal could change in the same batch as tool result rendering, causing incorrect `isNew` evaluation for streaming results. The change lazy-initializes the `hasLoadedSinceMount` snapshot on first `isNew()` call instead of eagerly in the constructor, ensuring the current loading state is captured at the right time and cached for the rest of the session.
update toolResultTracker.ts
update MessagePartRenderer.tsx
update MessagePartRenderer.tsx
…enderer, toolResultTracker update conversations: MessagePartRenderer, toolResultTracker
…nderer, toolResultTracker update conversations: MessagePartRenderer, toolResultTracker
…te, not newness Change the `ToolResultPartRenderer` to expand the result section when `isLoading` is true instead of when `isNew` is true. This fixes a race condition where tool results appearing in the same reactive batch as `isLoading=false` would incorrectly start collapsed. Remove stale comments in `toolResultTracker.ts` and `console.log` debug statements. Update test expectations to match the new behavior where results remain expanded during loading and re-expand when previously collapsed results become loading again.
…ection, MessagePartRenderer update conversations: CollapsibleSection, MessagePartRenderer
update CollapsibleSection.tsx
update CollapsibleSection.tsx
update CollapsibleSection.tsx
…ection, MessagePartRenderer update conversations: CollapsibleSection, MessagePartRenderer
update MessagePartRenderer.tsx
update 0009-tool-result-collapse.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.