Changed jogging record to reference API jogging data#2
Open
tnraddatz wants to merge 1 commit into
Open
Conversation
When a NEW jogging record was created, the previous implementation of the createOrUpdateJogging() would use the jogging record from the angular form, instead of using the jogging record being returned from the backend API. This resulted in jogging records being pushed to the JoggingData array that did NOT contain a valid Id, "undefined". This change allows a user to edit and delete newly created jogging records without having to refresh the window to pull the Id from a get request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a NEW jogging record was created, the previous implementation of this.joggingData.push(jogging) would use the jogging record from the angular form, instead of using the jogging record being returned from the backend API. This resulted in jogging records being pushed to the JoggingData array that did NOT contain a valid Id, "undefined". This change allows a user to edit and delete newly created jogging records without having to refresh the window to update the record id using a get request.