Add files - #2
Open
erofeevskiy-ia wants to merge 1 commit into
Open
Conversation
ver 0.4
| </div> | ||
|
|
||
| <div class="todo-filter" data-filter="all" aria-label="Фильтр : показ всех"> | ||
| <button class="todo-filter __active" > <!-- Модификатор??--> |
There was a problem hiding this comment.
Достаточно одного модификатора, чтобы показать стейт. В остальные места прокидывать не надо
| 3 items left | ||
| </div> | ||
|
|
||
| <div class="todo-filter" data-filter="all" aria-label="Фильтр : показ всех"> |
|
|
||
| <div class="todo-item"> <!--модификатор??--> | ||
| <div class="todo-item_ready-mark"> | ||
| <input type="checkbox" id="todo-item_ready-mark3" class="todo-item_ready-mark" value="cb_html" |
| } | ||
|
|
||
| .todo_footer_1 { | ||
| width: 444px; |
There was a problem hiding this comment.
нельзя хардкодить ширину, см разбор домашнего задания по css
| @@ -0,0 +1,242 @@ | |||
|
|
|||
There was a problem hiding this comment.
нужно сбросить стили на на используемые элементы, в том числе и на . см reset.scss в репе со стабом препроцессора
| overflow: hidden; | ||
| border:none; | ||
| background: inherit; | ||
| width:70%; |
There was a problem hiding this comment.
% !== честный адапитв
см https://cloud.mail.ru/public/JdWC/71ADpXe2W
|
|
||
|
|
||
|
|
||
| input[type=checkbox] { |
There was a problem hiding this comment.
Так нельзя. Это будет действовать на все чекбоксы
| @@ -0,0 +1,242 @@ | |||
|
|
|||
There was a problem hiding this comment.
Разделить файл на компоннеты согласно методоллгии
| } | ||
|
|
||
| .todo-item_remove{ | ||
| -ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=0)"; |
|
|
||
| -webkit-border-radius: 50px; | ||
| -moz-border-radius: 50px; | ||
| border-radius: 50px; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ver 0.4