Fix SECURITY DEFINER IDOR in get_following_feed RPC#127
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 46 minutes and 48 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as superseded by #126. Both PRs fix the same |
Motivation
SECURITY DEFINERRPCpublic.get_following_feedtrusted a caller-suppliedp_user_idand could bypass RLS to leak private posts anddaily_usagedata.p_limitparameter.Description
v_auth_user := auth.uid()and reject requests wherev_auth_user IS NULL OR v_auth_user <> p_user_idusingRAISE EXCEPTION ... ERRCODE = '42501'to prevent authenticated IDOR access.p_limitserver-side withv_limit := LEAST(GREATEST(COALESCE(p_limit, 20), 1), 100)and useLIMIT v_limitto cap page sizes.GRANT EXECUTEtoauthenticatedso intended client behavior is unchanged for legitimate callers.Testing
Codex Task