Skip to content

[codex] Refactor message and push presentation#124

Draft
ohong wants to merge 2 commits into
mainfrom
codex-thermo-quality-refactor
Draft

[codex] Refactor message and push presentation#124
ohong wants to merge 2 commits into
mainfrom
codex-thermo-quality-refactor

Conversation

@ohong

@ohong ohong commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • Split the oversized messages inbox into a stateful container plus focused message presentation and attachment utilities, bringing the main component under the 1k-line review threshold.
  • Added a shared clipboard feedback hook and reused it across landing, feed, post creation, and profile invite copy flows.
  • Moved CLI push summary/plain-text rendering into a dedicated output helper so push orchestration stays focused on sync behavior.

Why

This came out of a thermo-nuclear code quality review across landing page, web app, and CLI. The selected changes reduce structural complexity without changing product behavior: the web app sheds a >1k-line component hotspot, repeated clipboard timer logic is centralized, and CLI output rendering no longer sits inside the sync command's control flow.

Validation

  • bun vitest run tests/components/MessagesInbox.test.tsx (apps/web)
  • bun vitest run tests/commands/push.test.ts (packages/cli)
  • bun run typecheck (apps/web)
  • bun run typecheck (packages/cli)
  • bun run lint (apps/web)
  • bun run test (apps/web): 69 files / 590 tests passed
  • bun run test (packages/cli, unsandboxed for local 127.0.0.1 bind): 21 files / 278 tests passed
  • bun run build (monorepo): 3 tasks successful

Notes

  • The initial sandboxed monorepo test run failed because CLI API tests could not bind 127.0.0.1; rerunning the CLI package tests outside the sandbox passed.
  • packages/cli/src/lib/ccusage.ts has an unstaged local change that is not part of this PR.

@vercel

vercel Bot commented Jun 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
straude Ready Ready Preview, Comment Jun 2, 2026 7:48am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2cc4d2f3-92e1-4540-b9da-ca52f8ed1537

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex-thermo-quality-refactor

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant