You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is_aarch64_feature_detected is available, and also is_arm_feature_detected with the stdsimd feature enabled. ARM32 support actually depends on this feature to work, something I didn't notice when writing #53. These should be added.
I tried using https://github.com/cross-rs/cross to try out building for various platforms. It seems the target_arch in the build.rs does not match the actual target platform for some reason, while the environment variable CARGO_CFG_TARGET_ARCH does have the appropriate value. This is annoying because using is_x86_feature_detected requires usage #[cfg(any(target_arch = "x86", target_arch = "x86_64"))].
For instance when doing cross test --target aarch64-unknown-linux-gnu, target_arch in build.rs is x86_64, so it does not check for the correct target features. It looks like an universally complex topic. In the meantime I am also exploring the runtime feature resolution, but that would require a fallback, as we don't want the crate to build but to panic at runtime.
ogxd
changed the title
Detect CPU features at build time
Draft: Detect CPU features at build time
Jan 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.