Fix SwiftPM portability, sentence splitting, CI, and README accuracy#5
Merged
joelnishanth merged 13 commits intoApr 26, 2026
Conversation
Fix SentenceAwareChunker loop to resolve CI compile error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
swift buildandswift teston a supported macOS runner.Description
mlx-swift-lmfromPackage.swiftso the core library is backend-agnostic and keeps productMLXSwiftChainand package namemlx-swift-chainintact.MLXBackendconditionally available using#if canImport(MLXLMCommon)so MLX-specific integration does not block builds whereMLXLMCommonis absent.Stringsentence enumeration using unavailable.bySentenceswith a regex-based splitter inSentenceAwareChunkerto supportswift-corelibs-foundationon Linux.@_exported import struct Foundation.Durationre-export that prevented compilation..github/workflows/ci.ymlto run onmacos-latestand execute bothswift buildandswift test.README.mdto clarify that the “100%” figures refer to model-visible/input coverage across chunks (not guaranteed final-answer retention), and note that timestamp/speaker-label discovery is lightweight regex-based extraction rather than a full diarization pipeline; update requirements toSwift 6.1+and noteMLXBackendavailability.Testing
swift package describeand it completed successfully.swift buildlocally and the build completed successfully.swift testlocally and all automated tests passed (28 tests).Codex Task