Refactor SentenceAwareChunker chunking logic, bump Swift tools, and pin Xcode in CI#4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
6.1.latest-stable.Description
SentenceAwareChunkerto use sentence indices and accumulatechunkWordCountwith explicit start/end indexes, producing consistentsourceWordRangeand metadata for eachTextChunk.targetWords, enforce at-least-one-sentence per chunk, and implement sentence overlap rewind usingoverlapSentencesto compute the nextsentenceIndexcorrectly.// swift-tools-versioninPackage.swiftfrom5.9to6.1to adopt the newer Swift toolchain.16.3in.github/workflows/ci.ymlinstead oflatest-stable.Testing
swift testagainst the package and the test suite completed successfully.macos-14with Xcode16.3and will executeswift testas part of checks.Codex Task