fix: overlay aspect ratio, app icon, and CI dedup#10
Merged
Conversation
UpdateScale applied independent X/Y scale factors, so a saved 4:3 window config against a 16:9 camera produced a squished image. PresentFrame now snaps the window width to preserve the camera's native aspect ratio at the current height whenever the frame dimensions change (typically once at start). OverlaySizer.Resize then captures the corrected ratio, keeping subsequent wheel resizes undistorted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Convert cos.png to multi-resolution cos.ico (16/32/48/256 px) and wire it as ApplicationIcon so the exe and taskbar show the camera icon instead of the Windows default. Set Company/Product/AssemblyTitle/Description in the csproj so file Properties > Details shows correct metadata. Add SetupIconFile to the Inno Setup script so the installer wizard also uses the icon. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CI already ran on the PR head; re-running on merge adds no coverage. Direct pushes to main are expected to go through PRs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cos.pngto a multi-resolutioncos.ico(16/32/48/256 px); wires it asApplicationIconin the csproj so the exe, taskbar, and Explorer all show the camera icon; setsCompany,Product,AssemblyTitle,Descriptionin the csproj; addsSetupIconFileto the Inno Setup scriptpush: branches: [main]trigger — CI already ran on the PR head, re-running on merge adds no coverageTest plan
officialdad, Product:Camera on Screen🤖 Generated with Claude Code