Skip to content

fix: Set workflow to implicitly upload the docker image to the privat… #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liranm-odigos merged 1 commit into from
Jun 23, 2026
Merged

fix: Set workflow to implicitly upload the docker image to the privat… #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,22 +64,26 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

# Build packages (both archs) and multi-arch image; image is pushed to GCP_REGISTRY when PUSH=1
# Build packages (both archs) and multi-arch image; image is pushed to GCP_REGISTRY when PUSH=1,
# then the same manifest is copied to GCP_PRIVATE_REGISTRY so both registries hold an identical image.
- name: Build and package ${{ matrix.service }}
working-directory: ${{ matrix.service }}
run: |
make -j package-all build-all \
TAG="${{ env.TAG }}" \
REGISTRY="${{ env.GCP_REGISTRY }}" \
PUSH=1
docker buildx imagetools create \
--tag "${{ env.GCP_PRIVATE_REGISTRY }}/odigos-demo-${{ matrix.service }}:${{ env.TAG }}" \
"${{ env.GCP_REGISTRY }}/odigos-demo-${{ matrix.service }}:${{ env.TAG }}"

# Copy the multi-arch manifest list from GCP to GHCR (demo has no image)
# Copy the multi-arch manifest list from GCP to GHCR (demo has no image).
# Both GCP registries are identical, so a single source is used here.
- name: Tag and push multi-arch image to GitHub Container Registry
if: matrix.service != 'demo'
run: |
docker buildx imagetools create --tag "ghcr.io/${{ github.repository }}/odigos-demo-${{ matrix.service }}:${{ env.TAG }}" \
"${{ env.GCP_REGISTRY }}/odigos-demo-${{ matrix.service }}:${{ env.TAG }}" \
"${{ env.GCP_PRIVATE_REGISTRY }}/odigos-demo-${{ matrix.service }}:${{ env.TAG }}"
"${{ env.GCP_REGISTRY }}/odigos-demo-${{ matrix.service }}:${{ env.TAG }}"

- name: Upload Linux packages to Artifact Registry
if: matrix.service != 'demo'
Expand Down
Loading