fix: PHP metrics exporter crashing on shutdown#24
Merged
Conversation
…e Odigos prefix in MetricConverter and NoopTracerProvider
…to version 6.4.33; adjust dependencies and fix minor code formatting issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our PHP-Scoper config was incorrectly prefixing bare namespace-alias imports like
use OpenTelemetry\SDK;→use Odigos\OpenTelemetry\SDK;, even thoughOpenTelemetry\SDKis inexclude-namespaces.This made type hints in
MetricConverter(andNoopTracerProvider) resolve to a non-existentOdigos\OpenTelemetry\SDK\Resource\ResourceInfoclass, causing aTypeErrorwhen the meter provider flushed on request shutdown.Fixed by adding a patcher in
_helpers/scoper.inc.phpthat strips theOdigos\prefix back offusestatements for the excludedOpenTelemetry\{SDK,API,Context,SemConv}namespaces, and patched the generated vendor files.emergency-ticket id: EMR-1548