ci: guard release-lane workflows against tags on unexpected branches#5360
Draft
shivanshuraj1333 wants to merge 1 commit into
Draft
ci: guard release-lane workflows against tags on unexpected branches#5360shivanshuraj1333 wants to merge 1 commit into
shivanshuraj1333 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
publish-modules.ymltriggers onpush: tags: v*with no branch restriction — GitHub Actions can't scope a tag-push trigger to a branch. Today, av*-shaped tag pushed to any branch (a feature branch, a fork, anywhere) fires the full production release pipeline: real image pushes to GCR/DockerHub/GHCR, real Slack alerts, and for-rcNtags, a real Homebrew tap update.What
Adds a check at the top of the
decidejob: verifies the pushed (or dispatched) tag is reachable frommainorreleases/**before anything downstream runs. Fails fast with a clear error otherwise.Companion PR
Same guardrail mirrored in
odigos-enterprise'srelease-images.yml(separate PR).Part of the CI/CD pipeline hardening work discussed in CORE-1221.