feat(core): v0.3 failure detection rules — 5 new rules (15 total)#95
Merged
Conversation
Add SUSPICIOUS_SESSION_DURATION, SLOW_RESPONSE, HEARTBEAT_INTERVAL_VIOLATION, METER_VALUE_ANOMALY, and UNRESPONSIVE_CSMS detection rules. 14 new unit tests. All existing fixtures audited — no false positives. Closes #84
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements 5 new failure detection rules for v0.3.0 (Issues #84), bringing the total from 10 to 15:
SUSPICIOUS_SESSION_DURATION(warning) — Session < 60s or > 24hSLOW_RESPONSE(warning) — Call→CallResult/CallError gap > 10sHEARTBEAT_INTERVAL_VIOLATION(info) — Heartbeat intervals deviate >50% from expectedMETER_VALUE_ANOMALY(warning) — Non-monotonic or negative meter readingsUNRESPONSIVE_CSMS(critical) — Call with no matching CallResult or CallErrorImplementation
FailureCodevalues totypes.tsdetection.tsFiles Changed
packages/toolkit/src/core/types.ts— 5 new FailureCode valuespackages/toolkit/src/core/detection.ts— 5 rule implementations + suggested steps + severitypackages/toolkit/src/core/detection.test.ts— 14 new tests.changeset/v03-detection-rules.md— minor bump changesetCURRENT_STATE.md— updated with v0.3.0 progressCloses #84
Checklist
FailureCodevalues added totypes.tsdetection.tswith suggested stepsminorbumpCURRENT_STATE.mdupdated