fix(web): point npm links to toolkit package + inspector nav link#81
Merged
Conversation
npm links in README.md and landing page footer pointed to the npm organization page instead of the actual toolkit package page. - README.md: badge link + links section -> /package/@ocpp-debugkit/toolkit - apps/web/src/app/page.tsx: footer npm link -> same - apps/web/README.md: stale references to old packages (core, scenarios, reporter) -> @ocpp-debugkit/toolkit Also add a nav link from the inspector header to the root page, matching the docs layout pattern (link with 'OCPP DebugKit' + section label). - apps/web/src/app/inspector/page.tsx: wrap title in <Link href='/'> - Update E2E tests to match new header structure
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes bundled together:
1. npm links point to organization page instead of package page
The footer npm link on the landing page and both npm links in README.md pointed to
https://www.npmjs.com/org/ocpp-debugkit(the org page) instead of the actualpackage:
https://www.npmjs.com/package/@ocpp-debugkit/toolkit.Also fixed
apps/web/README.mdwhich still referenced the old deprecated packagenames (
@ocpp-debugkit/core,scenarios,reporter) instead of the consolidated@ocpp-debugkit/toolkit.2. Inspector header has no link back to root page
The docs layout has a working nav link (
OCPP DebugKit→/), but the inspectorheader was a plain
<h1>with no link. Updated to match the docs pattern: a<Link>to
/with the brand name, plus a small "Inspector" section label.Changes
README.md— badge link + links section:npmjs.com/org/...→npmjs.com/package/@ocpp-debugkit/toolkitapps/web/src/app/page.tsx— footer npm link: same fixapps/web/README.md— old package names →@ocpp-debugkit/toolkitapps/web/src/app/inspector/page.tsx— header<h1>→<Link href="/">+ section labelapps/web/tests/inspector.spec.ts— updated test for new header structureapps/web/tests/landing.spec.ts— updated navigation test for new header structureVerification
pnpm lint— passespnpm format:check— passespnpm typecheck— passespnpm build— passespnpm test— 295 tests passpnpm test:e2e— 16 Playwright tests pass