feat(react): extract reusable React components from inspector#76
Merged
Conversation
Replace stub objects with real React function components: - SessionTimeline: event list with click-to-select, timestamp/action/direction - MessageInspector: raw + normalized event fields, payload and raw JSON - FailureSummary: severity badges, descriptions, suggested steps - ReportViewer: iframe with srcdoc for HTML report rendering (no XSS) - ReplayControls: play/pause/step/scrubbar with speed selector All components use inline styles (no CSS framework dependency). SSR-safe (no window/document at module level). TypeScript prop types exported from types.ts. Added DOM lib to tsconfig for React event types. Closes #63
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Playwright strict mode violation: getByText('FAILED_AUTHORIZATION')
resolved to 4 elements (textarea trace JSON + 3 failure badges).
Add data-testid='failure-summary' to the failures section div and scope
the locator to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces stub objects with real React function components in
packages/toolkit/src/react/.Components
SessionTimelineMessageInspectorFailureSummaryReportViewersrcDocfor HTML report rendering (no XSS risk)ReplayControlsDesign
window/documentat module level)types.tsDOMandDOM.Iterableto toolkittsconfig.jsonlib for React event typesVerification
pnpm test— 295/295 tests passpnpm build— clean (toolkit + web)pnpm lint— cleanpnpm typecheck— cleanpnpm format:check— cleanCloses #63