fix(ci): add build step before publish + pass NPM_TOKEN as NODE_AUTH_TOKEN#49
Merged
Conversation
…TOKEN Two fixes for the release workflow: 1. Add 'pnpm build' step before changesets publish — dist/ must exist for npm publish (CLI bin was missing: 'No bin file found at dist/index.js') 2. Pass NPM_TOKEN as NODE_AUTH_TOKEN env var to the changesets action — npm reads NODE_AUTH_TOKEN for registry auth, not NPM_TOKEN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues in the release workflow that prevented npm publishing.
Root Causes
Missing build step — The release workflow ran
changeset publishwithout building first. The CLI'sdist/index.jsdidn't exist, causingNo bin file found at dist/index.jswarning and the publish failed.NPM_TOKEN not reaching npm — The changesets action received
NPM_TOKENenv var, butnpm publishreadsNODE_AUTH_TOKEN(set byactions/setup-nodewithregistry-url). TheNPM_TOKENwas empty in the logs, and even if set, npm wouldn't read it. Need to pass it as bothNPM_TOKEN(for changesets detection) andNODE_AUTH_TOKEN(for npm auth).Changes
pnpm buildstep before the changesets publish actionNODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}to the changesets envImportant: Verify NPM_TOKEN Secret
The user should verify the
NPM_TOKENGitHub secret:NPM_TOKENexists@ocpp-debugkitorg with publish permissions