fix(offer): point studio lever team photos at new blob store#208
Merged
Conversation
The 'studio' lever in offer.json referenced /images/team/{firstname}.{jpg,jpeg}
paths that do not exist under public/images/ — the offer page rendered broken
images on the team showcase row.
Rewrite the eight src values in locales/{fr,en}/offer.json to the canonical
slug-named team photos already published on the new website-blob store
(ipjmp3k0z0p479cb), matching the convention used by team frontmatter in the
posts content repo.
Closes #202.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
studiolever inLeviersSectionrendered 8 broken images:locales/{fr,en}/offer.jsonreferenced/images/team/{firstname}.{jpg,jpeg}butpublic/images/team/does not exist (verified — onlyexperience/,jobs/,partners/,studio.jpglive there).srcvalues to the canonical slug-named team photos already published on the newwebsite-blobstore (ipjmp3k0z0p479cb), matching how the posts repo stores team frontmatter avatars./images/partners/*files do exist locally.Closes #202.
Mapping applied
srcsrc/images/team/aude.jpg…/team/aude-cadiot.jpg/images/team/clara.jpg…/team/clara-lecarrie.jpg/images/team/corentin.jpeg…/team/corentin-guerin.jpeg/images/team/damien.jpg…/team/damien-robert.jpg/images/team/domitille.jpeg…/team/domitille-raimbault.jpeg/images/team/dorian.jpg…/team/dorian-cutullic.jpg/images/team/ethel.jpeg…/team/ethel-gosset.jpeg/images/team/louis.jpg…/team/louis-strauss.jpgTest plan
pnpm typecheck && pnpm checkgreen locally/offer(FR) and/en/offer— confirm the "Notre équipe" / "Our team" lever shows all 8 photos, no broken-image icons200