fix(dev): silence fetchPriority and i18n SSR warnings#205
Merged
Conversation
- Pass fetchpriority lowercase on OptimizedImage to dodge React 18.3.1's unknown-prop warning (its DOM allow-list lacks fetchPriority). - Bundle remix-i18next via ssr.noExternal so useChangeLanguage shares the same react-i18next module (and I18nContext) as our I18nextProvider, eliminating the spurious NO_I18NEXT_INSTANCE warning on SSR.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #204
Summary
fetchprioritylowercase onOptimizedImageso React 18.3.1 stops warning about the unknown camelCase prop (its DOM allow-list lacksfetchPriority).remix-i18nexttossr.noExternalsouseChangeLanguageshares the bundledreact-i18nextmodule instance and reads theI18nContextset by our<I18nextProvider>— eliminates theNO_I18NEXT_INSTANCESSR warning.Test plan
pnpm dev:local, hit/,/blog,/blog/:slug,/clients→ no warningspnpm checkgreenpnpm typecheckgreenpnpm test:run app/components/ui/optimized-image.test.tsxgreen