Optimize bulk operations by eliminating redundant LINQ operations#13
Open
oclockvn wants to merge 1 commit into
Open
Optimize bulk operations by eliminating redundant LINQ operations#13oclockvn wants to merge 1 commit into
oclockvn wants to merge 1 commit into
Conversation
This commit addresses two performance bottlenecks in bulk operations: 1. Cache identity columns in CachedEntityMetadata - Previously GetIdentityColumns() filtered columns on every call - Now computed once during metadata construction like PrimaryKeyColumns - Eliminates repeated LINQ Where().ToList() operations - Estimated ~5-10% improvement for upsert with IdentityOutput=true 2. Use pre-filtered column lists in BuildMergeSql - Previously filtered columns to exclude identity on every upsert - Now passes both allColumns and columnsWithoutIdentity from cache - Eliminates redundant Where(c => !c.IsIdentity).ToList() at line 441 - Estimated ~2-3% improvement for all upsert operations Files modified: - CachedEntityMetadata.cs: Added IdentityColumns property - EntityMetadataHelper.cs: GetIdentityColumns() now returns cached value - DbContextBulkExtension.cs: BulkUpsertAsync uses pre-filtered columns
Owner
Author
|
@claude review this PR, response with agree or disagree and explain the reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses two performance bottlenecks in bulk operations:
Cache identity columns in CachedEntityMetadata
Use pre-filtered column lists in BuildMergeSql
Files modified: