Skip to content

Update/assert equal markup in script deps tests #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sirreal merged 12 commits into from
Jun 5, 2025
Merged

Update/assert equal markup in script deps tests #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
802b33c
Update to use the new assertEqualMarkup helper
sirreal Jun 5, 2025
3fbc667
Rename test helper to assertEqualMarkup
sirreal Jun 5, 2025
6ec1a67
Fix script async/defer strategy expectation to match printed scripts
sirreal Jun 5, 2025
11a62c7
Add CDATA inline script wrappers where they appear in markup
sirreal Jun 5, 2025
d7faf35
FIXME: Skip an inaccurate test
sirreal Jun 5, 2025
0ea3520
Adjust expected output to use attributes as generated
sirreal Jun 5, 2025
f47af78
Add html5 support to a test that expects html5 support
sirreal Jun 5, 2025
1740a90
Script quotes in IE7 conditional _comments_ produce semantically _dif…
sirreal Jun 5, 2025
03c58ab
Revert irrelevant change
sirreal Jun 5, 2025
db681b8
Fix more missing CDATA comments
sirreal Jun 5, 2025
f294125
Remove scripts specific assertEqualMarkup implementation
sirreal Jun 5, 2025
e97bfbb
Use more consistent code backticks in docblock
sirreal Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/phpunit/includes/abstract-testcase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,11 +1195,11 @@ public function assertQueryTrue( ...$prop ) {
* @param string $actual The actual HTML.
* @param string|null $fragment_context Optional. The fragment context, for example "<td>" expected HTML
* must occur within "<table><tr>" fragment context. Default "<body>".
* Only `<body>` or `null` are supported at this time.
* Set to null to parse a full HTML document.
* Only "<body>" or `null` are supported at this time.
* Set to `null` to parse a full HTML document.
* @param string|null $message Optional. The assertion error message.
*/
public function assertEqualBlockMarkup( string $expected, string $actual, ?string $fragment_context = '<body>', $message = 'HTML markup was not equivalent.' ): void {
public function assertEqualMarkup( string $expected, string $actual, ?string $fragment_context = '<body>', $message = 'HTML markup was not equivalent.' ): void {
try {
$tree_expected = build_equivalent_html_semantic_tree( $expected, $fragment_context );
$tree_actual = build_equivalent_html_semantic_tree( $actual, $fragment_context );
Expand Down
Loading