Fix -Wincompatible-pointer-types-discards-qualifiers warning in speedtest1.c#801
Open
hnwyllmm wants to merge 1 commit into
Open
Fix -Wincompatible-pointer-types-discards-qualifiers warning in speedtest1.c#801hnwyllmm wants to merge 1 commit into
hnwyllmm wants to merge 1 commit into
Conversation
…s in speedtest1.c. Two -Wincompatible-pointer-types-discards-qualifiers warnings were generated during the compilation of sqlite-benchmark/speedtest1.c. The function sqlite3_expanded_sql returns a `char *` (non-const, requiring the caller to free it with sqlite3_free), but the code was receiving it in a `const char *` variable. This caused a discarding of the const qualifier when passing it to `sqlite3_free(void*)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During compilation of
sqlite-benchmark/speedtest1.c, two instances of the-Wincompatible-pointer-types-discards-qualifierswarning are generated.The function
sqlite3_expanded_sqlreturns achar *(non-const, requiring the caller to free it usingsqlite3_free). However, the code uses aconst char *to receive this pointer. This leads to discarding the const qualifier when the pointer is later passed tosqlite3_free(void*).Environment
Related Links