Skip to content

fix(intelligence): unify memory-type classification thresholds#936

Open
knqiufan wants to merge 1 commit into
oceanbase:mainfrom
knqiufan:fix/issue-935-unify-memory-type-thresholds
Open

fix(intelligence): unify memory-type classification thresholds#936
knqiufan wants to merge 1 commit into
oceanbase:mainfrom
knqiufan:fix/issue-935-unify-memory-type-thresholds

Conversation

@knqiufan
Copy link
Copy Markdown
Contributor

@knqiufan knqiufan commented May 23, 2026

Summary

  • Replace hardcoded 0.8 / 0.5 thresholds in IntelligentMemoryManager.process_metadata() with EbbinghausAlgorithm.long_term_threshold and short_term_threshold.
  • Add _classify_memory_type() so Manager and EbbinghausIntelligencePlugin use the same configuration source.
  • Add unit tests for default (0.6) and custom short_term_threshold boundary behavior.

Fixes #935

Test plan

  • pytest tests/unit/intelligence/test_intelligent_memory_manager.py -v

IntelligentMemoryManager now reads long_term_threshold and short_term_threshold from EbbinghausAlgorithm, matching EbbinghausIntelligencePlugin behavior. Add unit tests for boundary scores and custom config.

Fixes oceanbase#935
@zhanghuidinah zhanghuidinah requested a review from Teingi May 25, 2026 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent memory-type classification thresholds between EbbinghausIntelligencePlugin (0.6) and IntelligentMemoryManager (0.5)

1 participant