Fix missing XCircleIcon import in Plans.tsx#59
Open
PVTois wants to merge 1 commit into
Open
Conversation
Plans.tsx uses <XCircleIcon /> in the subscription-failed error card (line 182) but only imports CheckIcon and CreditCardIcon from lucide-react, so `npx tsc --noEmit` fails with: Plans.tsx(182,18): error TS2304: Cannot find name 'XCircleIcon'. Add XCircleIcon to the lucide-react import to fix the type error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
resources/js/Pages/Plans.tsxrenders<XCircleIcon />in the subscription-failed error card (line 182), but thelucide-reactimport on line 9 only brings inCheckIconandCreditCardIcon. As a result,npx tsc --noEmitfails:The icon only appears in the
form.isSubmitted && !form.isValidbranch, so it never surfaces in normal rendering — which is likely why it went unnoticed.Fix
Add
XCircleIconto the existinglucide-reactimport:One-line change, no behavior change.
npx tsc --noEmitpasses afterward.