fix: use safe type assertions to prevent panics#50
Merged
Conversation
Replace unsafe type assertions with comma-ok pattern to gracefully handle corrupted session data or unexpected types from gob deserialization. - auth.go: Safe assertion for user ID from session - msg.go: Safe assertion for flash messages - request.go: Safe assertions for CSRF, user, and config Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
felipekafuri
pushed a commit
to axioms-studio/bandeira
that referenced
this pull request
Feb 18, 2026
Replace unsafe type assertions with comma-ok pattern to gracefully handle corrupted session data or unexpected types from gob deserialization. - auth.go: Safe assertion for user ID from session - msg.go: Safe assertion for flash messages - request.go: Safe assertions for CSRF, user, and config Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
pkg/services/auth.go: Safe assertion for user ID from sessionpkg/msg/msg.go: Safe assertion for flash messagespkg/ui/request.go: Safe assertions for CSRF token, authenticated user, and configProblem
Direct type assertions like
value.(string)panic if the value is not of the expected type. This can happen when:Solution
Use the comma-ok idiom:
value, ok := x.(string)to safely check types and handle mismatches gracefully.🤖 Generated with Claude Code