fix: preserve existing Inertia props in ShareErrors()#49
Merged
Conversation
Add a new ShareErrors() function that properly merges validation errors with existing Inertia shared props instead of overwriting them. Changes: - Add ShareErrors() function to pkg/form/form.go that: - Retrieves existing props via gonertia.PropsFromContext() - Merges errors into existing props map - Sets combined props via gonertia.SetProps() - Add GetErrors() method to Form interface and Submission struct - Add comprehensive tests for ShareErrors behavior This prevents frontend crashes when form validation fails by ensuring auth, flash, and other shared props remain available to components. Fixes #48
felipekafuri
approved these changes
Jan 8, 2026
felipekafuri
pushed a commit
to axioms-studio/bandeira
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
ShareErrors()function that properly merges validation errors with existing Inertia shared props instead of overwriting them.Changes
ShareErrors()function topkg/form/form.gothat:gonertia.PropsFromContext()gonertia.SetProps()GetErrors()method toForminterface andSubmissionstructWhy This Matters
This prevents frontend crashes when form validation fails by ensuring auth, flash, and other shared props remain available to components.
Testing
Fixes #48