fix: handle danger toast case explicitly#47
Merged
Conversation
Fixes #42 The danger case was using fallthrough to error, which worked but was confusing. Now both cases are explicit for clarity.
felipekafuri
pushed a commit
to axioms-studio/bandeira
that referenced
this pull request
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42
The
dangercase inuseFlashToastswas using JavaScript fallthrough to theerrorcase. While this technically worked, it was confusing and looked like the case was empty/unhandled.Changes
dangercase explicit with its owntoast.error(message)callerrorcase for compatibilityBefore
After
Both approaches work identically, but the explicit version is clearer.