Fix issue #865#1439
Open
Tim-ats-d wants to merge 3 commits into
Open
Conversation
panglesd
reviewed
May 26, 2026
Collaborator
panglesd
left a comment
panglesd
left a comment
There was a problem hiding this comment.
I left some comments. This also needs a change entry!
Comment on lines
+171
to
+178
| let multilines_link_to_link link = | ||
| String.split_on_char '\n' link | ||
| |> List.map (fun line -> | ||
| String.trim @@ | ||
| if String.ends_with ~suffix:{|\|} line then | ||
| String.(sub line 0 (length line - 1)) | ||
| else line) | ||
| |> String.concat "" |
Collaborator
There was a problem hiding this comment.
This does not really correspond to what we expect (escaping newlines):
a
b\ <--- there are whitespace after the \
c\ <--- no newlines after the \
will be interpreted as abc. The biggest problem probably being that the trailing \ is removed (?)
Tim-ats-d
force-pushed
the
multines-line-link
branch
from
dc5e535 to
c245e0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First try to fix the issue #865. The patch is dead simple, I've only added a
multilines_link_to_linkwhich properly reformats multi lines link into normal ones.As I'm not yet really familiar with the Odoc codebase, don't hesitate to tell where can I define the
multilines_link_to_linkfunction or if the test need to reside in its own file!Cc @panglesd