Added feature flag for send message#761
Merged
Bert-R merged 2 commits intoJul 24, 2025
Merged
Conversation
Contributor
Author
|
@Bert-R can you please take a look, It disable the send message feature by default and make people feel confident to use the new version |
Bert-R
requested changes
Jul 22, 2025
Bert-R
left a comment
Bert-R
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this contribution! It was on my list to implement prior to releasing a new Kafdrop.
I've added two review comments. Please have a look.
Bert-R
approved these changes
Jul 24, 2025
Bert-R
left a comment
Bert-R
left a comment
Collaborator
There was a problem hiding this comment.
That looks good. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve: #756
Follow up for: #703
Create message feat is disabled by default
Set
--message.sendEnabled=trueif we want to use it