feat: Support resource display name and description metadata fields#115
Draft
jsirianni wants to merge 6 commits into
Draft
feat: Support resource display name and description metadata fields#115jsirianni wants to merge 6 commits into
jsirianni wants to merge 6 commits into
Conversation
|
Have the updates to Bindplane occurred to allow this PR to be merged? |
jsirianni
force-pushed
the
joesirianni/bpop-506-terraform-resource-display-name-and-description
branch
from
1734180 to
9188054
Compare
Member
Author
Hi @bradpoulton. Apologies, this slipped through the cracks. I just rebased the branch. Will revisit it soon. |
…ations, and extensions
jsirianni
force-pushed
the
joesirianni/bpop-506-terraform-resource-display-name-and-description
branch
from
dab3c63 to
b7b0f94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR depends on some pending BindPlane changes, and will not work as expected against current versions of BindPlane. This PR will remain in a draft state until the BindPlane changes are in place.
Added
display_nameanddescriptionparameters for components (sources, processors, destinations, extensions). The params behave the same for all four resource types, so I tried to make them as generic as possible.Resolves #109
Resolves #107
Please check that the PR fulfills these requirements