feat(bindplaneextension): implement support bundle streaming via OpAMP#416
Draft
itonyr wants to merge 1 commit into
Draft
feat(bindplaneextension): implement support bundle streaming via OpAMP#416itonyr wants to merge 1 commit into
itonyr wants to merge 1 commit into
Conversation
- internal/bundle: add defaultBundler (collects encrypted BNDL via support-util, POSTs to server with X-Bindplane-Session-ID) and defaultManager (parses request payload, drives collect+upload flow, sends error notification on failure) - config.go: replace flat EncryptionPublicKeyPath field with SupportBundleConfig sub-struct (OpAMPEndpoint, AgentID, paths, key) - extension.go: register com.bindplane.supportbundle capability on Start, drain handler.Message() in a goroutine, unregister on Shutdown Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
itonyr
commented
Jun 9, 2026
|
|
||
| // defaultEncryptionPublicKeyPEM is the RSA public key used to produce encrypted BNDL files | ||
| // when no override path is configured. The server holds the corresponding private key. | ||
| var defaultEncryptionPublicKeyPEM = []byte(`-----BEGIN PUBLIC KEY----- |
Contributor
Author
There was a problem hiding this comment.
This should be removed inline, the opamp server now pushes down the key Just in Time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Checklist