Add HRA intestine/liver/skin NTR template (4 new terms)#3716
Conversation
Generated via bulk_ntr_workflow from source_data/intestine-liver-skin.csv (5 input rows from large-intestine, liver, and skin tables): - 4 new UBERON terms (UBERON:8930100-8930102, UBERON:8930104): - free taenia coli (UBERON:8930100) - mesocolic taenia coli (UBERON:8930101) - omental taenia coli (UBERON:8930102) - connective tissue sheath (UBERON:8930104) - of hair follicle - 1 row excluded as out-of-scope: 'Liver immune resident component' (functional immune-cell collective; belongs in CL, not UBERON) Name corrections applied: 'free coli' -> 'free taenia coli' etc. (source ASCTB labels were incomplete; full anatomical nomenclature used). Signed-off-by: dragon-ai-agent <dragon-ai-agent@users.noreply.github.com>
|
Claude finished @zhengj2007's task in 5m 13s —— View job PR ReviewReview checklist:
Tasks:
SummaryThis PR adds 4 new UBERON terms for intestine/skin anatomy via ROBOT template, generated through the bulk NTR workflow. The scope decisions are well-reasoned (liver immune component correctly excluded as CL, not UBERON). However there are several issues that need to be fixed before merge. 🔴 CRITICAL: Template not registered in ODK YAML
Per the bulk NTR workflow docs (Stage 5), the registration script must be run: cd bulk_ntr_workflow
uv run scripts/register_templates.py --name hra-intestine-liver-skinThis should add an entry like: - filename: hra_intestine_liver_skin.owl
use_template: true
templates:
- hra-intestine-liver-skin.template.tsvto 🟡 IMPORTANT: Incorrect
|
There was a problem hiding this comment.
REQUEST CHANGES on PR #3716 (Add HRA intestine/liver/skin NTR template).
🔴 CRITICAL: Template hra-intestine-liver-skin.template.tsv is not registered in src/ontology/uberon-odk.yaml — without this the 4 new terms will never be compiled into the ontology build. Stage 5 (register_templates.py) was not run.
🟡 IMPORTANT:
- Taenia coli terms (8930100–8930102) use
is_a: UBERON:0004923+part_of: UBERON:0012419. The three named bands are subtypes of taenia coli (matching FMA's model of FMA:15041 and its subclasses), so the correct axioms areis_a: UBERON:0012419+part_of: UBERON:0011198(muscle layer of large intestine). - Duplicate non-standard
isBN:978-1496398949prefix (typo for ISBN) appears in all three taenia coli def_xrefs — must be removed. - UBERON:8930104 label
connective tissue sheathis too generic; should beconnective tissue sheath of hair follicle.
See detailed review in the Claude comment for fix suggestions.
Generated via bulk_ntr_workflow from source_data/intestine-liver-skin.csv (5 input rows from large-intestine, liver, and skin tables):
Name corrections applied: 'free coli' -> 'free taenia coli' etc. (source ASCTB labels were incomplete; full anatomical nomenclature used).