Forward all unknown attributes to latex lstlistings#116
Open
oberien wants to merge 1 commit into
Open
Conversation
197g
reviewed
Feb 14, 2020
| self.double.remove(key) | ||
| } | ||
|
|
||
| pub fn take_all_double(&mut self) -> HashMap<Cow<'a, str>, WithRange<Cow<'a, str>>> { |
Collaborator
There was a problem hiding this comment.
In Drop we warn for all unused attributes of a Cskvp. Using this method makes that more or less pointless.
| } else { | ||
| Some(WithRange(language, language_range)) | ||
| }, | ||
| attributes: cskvp.take_all_double(), |
Collaborator
There was a problem hiding this comment.
Maybe we could take some inspiration from html, and have a style attribute instead that contains options that should be forwarded? I'm not completely sure either.
I used this for a presentation to specify fontsize (`basicstyle=\tiny`) for listings. Shouldn't be a long-term solution in general, so unsure if we actually want to merge this?
oberien
force-pushed
the
latex-attribute-hack
branch
from
2bf111a to
265466b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used this for a presentation to specify fontsize (
basicstyle=\tiny)for listings. Shouldn't be a long-term solution in general, so unsure if
we actually want to merge this?