feat: Dynamic Metrics#17
Open
micrusa wants to merge 1 commit into
Open
Conversation
- Add ignored metrics that do not get exported to userConfig defined exporters (they do get exported to user defined readers) - Add dynamic exporting interval for userConfig defined exporters (it's ignored for user defined readers)
Collaborator
|
I think we should take a closer look at the Views concept. Let's schedule a meeting to discuss the implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exporters (they do get exported to user defined readers). Under POST/GET/DELETE /metrics/ignored
ignored for user defined readers). Under GET/POST /metrics/export-interval
Changes
Testing it out
npm run build&npm testTo test it manually, run dev environment with
npm run devDynamic intervals
curl -X GET http://localhost:3000/oas-telemetry/metrics/export-intervalMetric filtering (ignored scope names)
curl -X GET http://localhost:3000/oas-telemetry/metrics/ignoredcurl -X DELETE http://localhost:3000/oas-telemetry/metrics/ignored