Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

fix: remove fixed height on app shell#109

Draft
denkristoffer wants to merge 1 commit into
oae:mainfrom
denkristoffer:patch-1
Draft

fix: remove fixed height on app shell#109
denkristoffer wants to merge 1 commit into
oae:mainfrom
denkristoffer:patch-1

Conversation

@denkristoffer

Copy link
Copy Markdown

Pull Request Template

Description

The fixed height on the app shell means the chapter list table doesn't work too well on smaller screens, you can end up with just a single row in the table. This PR removes the set height.

Quick recording showing before and after:

Screen.Recording.2023-06-26.at.15.32.26.mov

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • My commits follow the commit standards of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant